chia7712 commented on code in PR #19962:
URL: https://github.com/apache/kafka/pull/19962#discussion_r2144435339
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2201,9 +2201,7 @@ class ReplicaManager(val config: KafkaConfig,
private def updateLeaderAndFollowerMetrics(newFollowerTopics: Set[String]):
Unit = {
val leaderTopicSet = leaderPartitionsIterator.map(_.topic).toSet
newFollowerTopics.diff(leaderTopicSet).foreach(brokerTopicStats.removeOldLeaderMetrics)
Review Comment:
`removeOldLeaderMetrics` tries to remove `REPLICATION_BYTES_OUT_PER_SEC` and
`REASSIGNMENT_BYTES_OUT_PER_SEC` which apply across all topics too. Could you
please remove them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
