chia7712 commented on code in PR #19964:
URL: https://github.com/apache/kafka/pull/19964#discussion_r2152687163


##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -855,7 +860,7 @@ private void sendProduceRequest(long now, int destination, 
short acks, int timeo
         if (batches.isEmpty())
             return;
 
-        final Map<TopicPartition, ProducerBatch> recordsByPartition = new 
HashMap<>(batches.size());
+        final Map<TopicIdPartition, ProducerBatch> recordsByPartition = new 
HashMap<>(batches.size());
         Map<String, Uuid> topicIds = topicIdsForBatches(batches);

Review Comment:
   > We always fall back on topic name if topic id not passed down
   
   IIRC, the topic name is ignored in RPC when the version is larger than 13. 
So, is it possible that the broker receives the produce request without both 
the topic name and id?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to