jolshan commented on code in PR #19976:
URL: https://github.com/apache/kafka/pull/19976#discussion_r2152736969


##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -977,10 +977,9 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
 
                   case Some(epochAndMetadata) =>
                     if (epochAndMetadata.coordinatorEpoch == coordinatorEpoch) 
{
-                      // This was attempted epoch fence that failed, so mark 
this state on the metadata
-                      epochAndMetadata.transactionMetadata.hasFailedEpochFence 
= true
+                      // For TV2, we allow re-bumping the epoch on retry, so 
don't set hasFailedEpochFence = true

Review Comment:
   For this comment, should we say that we don't complete the epoch bump so we 
can simply retry the epoch bump.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to