kevin-wu24 commented on code in PR #19589: URL: https://github.com/apache/kafka/pull/19589#discussion_r2153236002
########## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ########## @@ -3306,6 +3383,22 @@ private UpdateRaftVoterRequestData buildUpdateVoterRequest() { ); } + private AddRaftVoterRequestData buildAddVoterRequest() { + return RaftUtil.addVoterRequest( + clusterId, + quorumConfig.requestTimeoutMs(), + quorum.localReplicaKeyOrThrow(), + localListeners + ); Review Comment: Set `ackWhenCommitted = false` after https://github.com/apache/kafka/pull/19982 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org