cmccabe commented on code in PR #19974:
URL: https://github.com/apache/kafka/pull/19974#discussion_r2153238326
##########
metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java:
##########
@@ -199,13 +203,14 @@ AclDeleteResult deleteAclsForFilter(AclBindingFilter
filter,
StandardAcl acl = entry.getValue();
AclBinding binding = acl.toBinding();
if (filter.matches(binding)) {
- deleted.add(new AclBindingDeleteResult(binding));
- records.add(new ApiMessageAndVersion(
- new RemoveAccessControlEntryRecord().setId(id), (short)
0));
- if (records.size() > MAX_RECORDS_PER_USER_OP) {
+ // check size limitation first before adding additional records
+ if (records.size() == MAX_RECORDS_PER_USER_OP) {
Review Comment:
Using `>=` would be more future-proof I think...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
