m1a2st commented on code in PR #19993:
URL: https://github.com/apache/kafka/pull/19993#discussion_r2156301058


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java:
##########
@@ -200,7 +200,7 @@ public void verifyAssignmentId() {
         assertEquals(Collections.emptySet(), state.assignedPartitions());

Review Comment:
   ```suggestion
           assertEquals(Set.of(), state.assignedPartitions());
   ```



##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/SubscriptionStateTest.java:
##########
@@ -63,8 +63,8 @@ public class SubscriptionStateTest {
 
     @Test
     public void partitionAssignment() {
-        state.assignFromUser(singleton(tp0));
-        assertEquals(singleton(tp0), state.assignedPartitions());
+        state.assignFromUser(Set.of(tp0));
+        assertEquals(Set.of(tp0), state.assignedPartitions());
         assertEquals(1, state.numAssignedPartitions());
         assertFalse(state.hasAllFetchPositions());
         state.seek(tp0, 1);

Review Comment:
   L73 `Collections.emptySet()` -> `Set.of()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to