chia7712 commented on code in PR #19776:
URL: https://github.com/apache/kafka/pull/19776#discussion_r2156544696
##########
core/src/test/scala/unit/kafka/server/DescribeQuorumRequestTest.scala:
##########
@@ -91,11 +92,8 @@ class DescribeQuorumRequestTest(cluster: ClusterInstance) {
)(
Review Comment:
Could you please remove this method by using
`IntegrationTestUtils.connectAndReceive(request, cluster.boundPorts().get(0))`
directly?
##########
core/src/test/scala/unit/kafka/server/ShareGroupHeartbeatRequestTest.scala:
##########
@@ -931,11 +933,9 @@ class ShareGroupHeartbeatRequestTest(cluster:
ClusterInstance) {
}
private def connectAndReceive(request: ShareGroupHeartbeatRequest):
ShareGroupHeartbeatResponse = {
- IntegrationTestUtils.connectAndReceive[ShareGroupHeartbeatResponse](
- request,
- cluster.anyBrokerSocketServer(),
- cluster.clientListener()
- )
+ val socketServer = cluster.brokerSocketServers().asScala.head
+ val listenerName = cluster.clientListener()
+
IntegrationTestUtils.connectAndReceive[ShareGroupHeartbeatResponse](request,
socketServer.boundPort(listenerName))
Review Comment:
```scala
IntegrationTestUtils.connectAndReceive[ShareGroupHeartbeatResponse](request,
cluster.boundPorts().get(0))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
