apoorvmittal10 commented on code in PR #19998:
URL: https://github.com/apache/kafka/pull/19998#discussion_r2158643765
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -2324,8 +2325,8 @@ CompletableFuture<Void>
writeShareGroupState(List<PersisterStateBatch> stateBatc
PartitionErrorData partitionData = state.partitions().get(0);
if (partitionData.errorCode() != Errors.NONE.code()) {
KafkaException ex =
fetchPersisterError(partitionData.errorCode(), partitionData.errorMessage());
- log.error("Failed to write the share group state for share
partition: {}-{} due to exception",
- groupId, topicIdPartition, ex);
+ logError(String.format("Failed to write the share group
state for share partition: %s-%s due to exception",
+ groupId, topicIdPartition), ex);
Review Comment:
I read `logError` as `log.error` with `String.format`, hence was wondering
why you needed the change. It makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
