AndrewJSchofield commented on code in PR #20006:
URL: https://github.com/apache/kafka/pull/20006#discussion_r2159319554


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2575,6 +2576,10 @@ private 
CoordinatorResult<Map.Entry<ShareGroupHeartbeatResponseData, Optional<In
             records
         ) || initializedAssignmentPending(group);
 
+        if (bumpGroupEpoch) {
+            metrics.record(SHARE_GROUP_REBALANCES_SENSOR_NAME);

Review Comment:
   Is there any reason why this metric is not recorded on line 2618, just after 
the `log.info("[GroupId {}] Bumped group epoch...`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to