YutaLin commented on code in PR #19807:
URL: https://github.com/apache/kafka/pull/19807#discussion_r2160790479


##########
clients/src/main/java/org/apache/kafka/server/quota/ClientQuotaCallback.java:
##########
@@ -44,7 +45,7 @@ public interface ClientQuotaCallback extends Configurable {
      * @param clientId  The client id associated with the request
      * @return quota metric tags that indicate which other clients share this 
quota
      */
-    Map<String, String> quotaMetricTags(ClientQuotaType quotaType, 
KafkaPrincipal principal, String clientId);
+    LinkedHashMap<String, String> quotaMetricTags(ClientQuotaType quotaType, 
KafkaPrincipal principal, String clientId);

Review Comment:
   I thought we could ensure that the order of the metric tags is preserved 
from the source.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to