zzbennett commented on code in PR #20061:
URL: https://github.com/apache/kafka/pull/20061#discussion_r2174704798
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -1921,14 +1921,14 @@ private
CompletableFuture<DeleteShareGroupOffsetsResponseData> handleDeleteShare
errorTopicResponses.add(
new
DeleteShareGroupOffsetsResponseData.DeleteShareGroupOffsetsResponseTopic()
.setTopicId(topicData.topicId())
-
.setTopicName(metadataImage.topics().topicIdToNameView().get(topicData.topicId()))
+
.setTopicName(metadataImage.topicName(topicData.topicId()).orElse("<UNKNOWN>"))
Review Comment:
Yea before we were returning `null`. I had seen some other places where we
were setting topic name to `<UNKNOWN>` e.g.
https://github.com/apache/kafka/blob/12d593bf6f52013b6b288d25aa40f80cc470785f/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java#L1924
but to maintain the existing behavior we can just keep it as null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
