dajac commented on code in PR #20055:
URL: https://github.com/apache/kafka/pull/20055#discussion_r2175071385
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2250,13 +2250,15 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord>
records
);
- bumpGroupEpoch |= maybeUpdateRegularExpressions(
+ UpdateRegularExpressionsResult updateRegularExpressionsResult =
maybeUpdateRegularExpressions(
Review Comment:
nit: Would it make sense to define the following variables?
- subscribedTopicNamesChanged
- subscribedTopicRegexChanged (already part of
updateRegularExpressionsResult)
Then we can define:
- hasSubscriptionChanged = subscribedTopicNamesChanged |
subscribedTopicRegexChanged
- bumpGroupEpoch = group.groupEpoch() == 0 | subscribedTopicNamesChanged |
updateRegularExpressionsResult.bumpGroupEpoch.
For both, we can put a comment explaining the differences. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
