gaurav-narula commented on code in PR #20072:
URL: https://github.com/apache/kafka/pull/20072#discussion_r2175532571
##########
core/src/test/java/kafka/server/LogManagerIntegrationTest.java:
##########
@@ -59,6 +61,70 @@ public LogManagerIntegrationTest(ClusterInstance cluster) {
this.cluster = cluster;
}
+ @ClusterTest(types = {Type.KRAFT})
+ public void testIOExceptionOnLogSegmentCloseResultsInRecovery() throws
IOException, InterruptedException, ExecutionException {
+ try (Admin admin = cluster.admin()) {
+ admin.createTopics(List.of(new NewTopic("foo", 1, (short)
1))).all().get();
+ }
+ cluster.waitForTopic("foo", 1);
+
+ // Produce some data into the topic
+ Map<String, Object> producerConfigs = Map.of(
+ ProducerConfig.BOOTSTRAP_SERVERS_CONFIG,
cluster.bootstrapServers(),
+ ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName(),
+ ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG,
StringSerializer.class.getName()
+ );
+
+ try (Producer<String, String> producer = new
KafkaProducer<>(producerConfigs)) {
+ producer.send(new ProducerRecord<>("foo", 0, null, "bar")).get();
+ producer.flush();
+ }
+
+ var broker = cluster.brokers().get(0);
+
+ File timeIndexFile = broker.logManager()
+ .getLog(new TopicPartition("foo", 0), false).get()
+ .activeSegment()
+ .timeIndexFile();
+
+ // Set read only so that we throw an IOException on shutdown
+ assertTrue(timeIndexFile.exists());
+ assertTrue(timeIndexFile.setReadOnly());
+
+ broker.shutdown();
+
+ assertEquals(1, broker.config().logDirs().size());
+ String logDir = broker.config().logDirs().head();
Review Comment:
This cherry-pick uses `logDirs().head()` instead of `logDirs().get(0)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
