xijiu commented on code in PR #20064:
URL: https://github.com/apache/kafka/pull/20064#discussion_r2176219472
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##########
@@ -1053,6 +1055,64 @@ public void
testDescribeNonOffsetCommitGroup(ClusterInstance clusterInstance) th
}
}
+ /**
+ * The config `OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG` needs to be set to
a value greater than 1 to ensure the
+ * normal invocation of APIs such as `FIND_COORDINATOR` when a broker has
shutdown
+ */
+ @Timeout(60)
+ @ClusterTest(brokers = 3, serverProperties = {@ClusterConfigProperty(key =
OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "2")})
+ public void testDescribeConsumerGroupWithoutLeaders(ClusterInstance
clusterInstance) throws Exception {
+ int brokerNum = 3;
+ this.clusterInstance = clusterInstance;
+
+ // define topic and group, then send 5 records to each partition
+ String topic = TOPIC_PREFIX + UUID.randomUUID();
+ String group = GROUP_PREFIX + UUID.randomUUID();
+ clusterInstance.createTopic(topic, brokerNum, (short) 1);
+ for (int i = 0; i < brokerNum; i++) {
+ sendRecords(topic, i, 5);
+ }
+
+ // append the command
+ List<String> cgcArgs = List.of("--bootstrap-server",
clusterInstance.bootstrapServers(), "--describe", "--group", group,
"--all-topics");
+
+ try (AutoCloseable protocolConsumerGroupExecutor =
consumerGroupClosable(GroupProtocol.CLASSIC, group, topic, Map.of());
+ ConsumerGroupCommand.ConsumerGroupService service =
consumerGroupService(cgcArgs.toArray(new String[0]));
+ Admin admin = clusterInstance.admin()
+ ) {
+ // shutdown the target broker
+ int noneLeaderPartition = 2;
+ int shutdownBrokerId = clusterInstance.getLeaderBrokerId(new
TopicPartition(topic, noneLeaderPartition));
+ clusterInstance.shutdownBroker(shutdownBrokerId);
+
+ TestUtils.waitForCondition(() -> {
+ Entry<String, String> res =
ToolsTestUtils.grabConsoleOutputAndError(describeGroups(service));
+ String[] lines = res.getKey().trim().split("\n");
+ if (lines.length != 4 || !res.getValue().isEmpty()) {
+ return false;
+ }
+
+ // get the client data, such as `consumerId,host,clientId`, to
append the expected output
+ ConsumerGroupDescription consumerGroupDescription =
admin.describeConsumerGroups(Set.of(group)).describedGroups().get(group).get();
+ MemberDescription memberDescription =
consumerGroupDescription.members().iterator().next();
+ String consumerId = memberDescription.consumerId();
+ String host = memberDescription.host();
+ String clientId = memberDescription.clientId();
+
+ // the expected output
+ List<String> partition0content = List.of(group, topic, "0",
"5", "5", "0", consumerId, host, clientId);
+ List<String> partition1content = List.of(group, topic, "1",
"5", "5", "0", consumerId, host, clientId);
+ List<String> partition2content = List.of(group, topic, "2",
"-", "-", "-", consumerId, host, clientId);
+
+ return checkArgsHeaderOutput(cgcArgs, lines[0])
+ &&
Arrays.stream(lines[1].trim().split("\\s+")).toList().equals(partition0content)
+ &&
Arrays.stream(lines[2].trim().split("\\s+")).toList().equals(partition1content)
+ &&
Arrays.stream(lines[3].trim().split("\\s+")).toList().equals(partition2content);
+ }, "Expected a data row and no error in describe groups when a
broker shutdown.");
Review Comment:
@FrankYang0529 Yeah, I have fixed it, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
