lucasbru commented on code in PR #20070:
URL: https://github.com/apache/kafka/pull/20070#discussion_r2176918934
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##########
@@ -580,7 +587,7 @@ private static boolean verify(final PrintStream
resultStream,
if (printResults) {
resultStream.printf("\t inputEvents=%n%s%n\t" +
"echoEvents=%n%s%n\tmaxEvents=%n%s%n\tminEvents=%n%s%n\tdifEvents=%n%s%n\tcntEvents=%n%s%n\ttaggEvents=%n%s%n",
- indent("\t\t", observedInputEvents.get(key)),
+ indent("\t\t",
observedInputEvents.getOrDefault(key, new LinkedList<>())),
Review Comment:
Collections.emptyList() and List.of() don't return a linked list.
Since this is test code, I wouldn't worry about unnecessary allocations.
I could try to refactor the test to not use LinkedLists, however that would
at least require rerunning the system test for 8+ hours, so I'd only do that if
you feel strongly about your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
