jiafu1115 commented on PR #20007: URL: https://github.com/apache/kafka/pull/20007#issuecomment-3026447627
@FrankYang0529 @showuon thanks for comments and suggestions. In fact. Some codes already try to catch the exception to shutdown the server. But it failed to catch it in this case. That's why I don't propose to check and catch the error for all the possible cases. https://github.com/apache/kafka/blob/eaa55c420bcfc0fdcb8affedf840cf0b4e9cf191/storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java#L59-L62 And you can see the code using the Exit. What's more, for the exception self. the document already said that it can be used in server. https://github.com/apache/kafka/blob/eaa55c420bcfc0fdcb8affedf840cf0b4e9cf191/clients/src/main/java/org/apache/kafka/common/internals/FatalExitError.java#L22-L23 for this approach: change initializeResources to be synchronized. I am worrying if it can be workable as I comments here https://github.com/apache/kafka/pull/20007#issuecomment-3004014985 WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
