LoganZhuZzz commented on code in PR #20089:
URL: https://github.com/apache/kafka/pull/20089#discussion_r2181635737
##########
checkstyle/import-control-coordinator-common.xml:
##########
@@ -61,11 +60,13 @@
<allow pkg="org.apache.kafka.server.authorizer" />
<allow pkg="org.apache.kafka.server.common" />
<allow pkg="org.apache.kafka.server.metrics" />
+ <allow pkg="org.apache.kafka.server.storage" />
<allow pkg="org.apache.kafka.server.util" />
<allow pkg="org.apache.kafka.storage.internals.log" />
<allow pkg="org.apache.kafka.test" />
<allow pkg="org.apache.kafka.timeline" />
<allow pkg="org.HdrHistogram" />
+ <allow pkg="scala" />
Review Comment:
Would you prefer that we wait until `ReplicaManager` is refactored into Java
before removing all Scala dependencies from this module, or would it make more
sense to move these tests elsewhere, or wrap the Scala APIs in Java-friendly
facade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
