FrankYang0529 commented on code in PR #18350: URL: https://github.com/apache/kafka/pull/18350#discussion_r2185514967
########## docs/ops.html: ########## @@ -3923,6 +3923,10 @@ <h5 class="anchor-heading"><a id="kraft_reconfig_add" class="anchor-link"></a><a After starting the controller, the replication to the new controller can be monitored using the <code>bin/kafka-metadata-quorum.sh describe --replication</code> command. Once the new controller has caught up to the active controller, it can be added to the cluster using the <code>bin/kafka-metadata-quorum.sh add-controller</code> command. + The <code>--command-config</code> needs to point to the to-be-added controller's configuration file. + + The <code>controller.quorum.bootstrap.servers</code> property in <code>--command-config</code> file needs to contain an active controller in the quorum. + Review Comment: Hi @ahuang98, thanks for the review. Since the PR points to the trunk branch and all configurations are under `config` folder, not `config/kraft`, I think it's ok to keep `config/controller.properties`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
