Yunyung commented on code in PR #20021:
URL: https://github.com/apache/kafka/pull/20021#discussion_r2190739644
##########
metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java:
##########
@@ -356,11 +355,12 @@ private void maybePublishMetadata(MetadataDelta delta,
MetadataImage image, Load
metadataVersion.featureLevel()
);
- // Set all production feature levels from the image, defaulting to
their minimum production values
- for (var feature : Feature.PRODUCTION_FEATURES) {
+ // Set all production feature levels from the image
+ for (var featureEntry :
image.features().finalizedVersions().entrySet()) {
+
metrics.maybeRemoveFinalizedFeatureLevelMetrics(image.features().finalizedVersions());
Review Comment:
This line should be outside the loop, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
