jim0987795064 commented on code in PR #20068:
URL: https://github.com/apache/kafka/pull/20068#discussion_r2190913989


##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -1298,11 +1298,11 @@ object TestUtils extends Logging {
     adminClient.incrementalAlterConfigs(configs)
   }
 
-  def assertLeader(client: Admin, topicPartition: TopicPartition, 
expectedLeader: Int): Unit = {

Review Comment:
   Hello @TaiJuWu, to use `assertLeader` as the first parameter of 
`sleepMillisToPropagateMetadata`, I think we need to change the return type of 
`assertLeader`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to