junrao commented on code in PR #20121:
URL: https://github.com/apache/kafka/pull/20121#discussion_r2190953126
##########
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala:
##########
@@ -224,6 +224,9 @@ class LogRecoveryTest extends QuorumTestHarness {
server1.startup()
updateProducer()
+ waitUntilTrue(() =>
server2.replicaManager.onlinePartition(topicPartition).get.inSyncReplicaIds.size
== 2,
Review Comment:
Hmm, why is this needed? Later on, there is another waitUntilTrue(). That
should be enough, right?
```
TestUtils.waitUntilTrue(() =>
server1.replicaManager.localLogOrException(topicPartition).highWatermark == hw,
"Failed to update high watermark for follower after timeout")
```
Also, from the jira, the failure happened in the following line.
` leader = awaitLeaderChange(servers, topicPartition, oldLeaderOpt =
Some(leader), timeout = 30000L)
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
