ahuang98 commented on code in PR #19847:
URL: https://github.com/apache/kafka/pull/19847#discussion_r2191169199
##########
metadata/src/main/java/org/apache/kafka/image/ClientQuotaImage.java:
##########
@@ -45,15 +45,15 @@ public final class ClientQuotaImage {
private final Map<String, Double> quotas;
public ClientQuotaImage(Map<String, Double> quotas) {
- this.quotas = quotas;
+ this.quotas = Collections.unmodifiableMap(quotas);
}
Map<String, Double> quotas() {
return quotas;
}
public Map<String, Double> quotaMap() {
- return Collections.unmodifiableMap(quotas);
+ return this.quotas;
Review Comment:
we have a duplicate method now for accessing the quotas map, can we get rid
of one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
