lucasbru commented on code in PR #19967:
URL: https://github.com/apache/kafka/pull/19967#discussion_r2192301427


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -462,6 +465,11 @@ GroupMetadataManager build() {
      */
     private final TimelineHashMap<String, Group> groups;
 
+    /**
+     * The classic and consumer groups keyed by their name.
+     */
+    private final Map<String, List<GroupConfigListener>> groupConfigListeners;

Review Comment:
   As above, I wonder if we could avoid this by just having the `StreamsGroup` 
object "listen".
   
   And as above, this seems to introduce a memory leak, since we never seem to 
remove a listener from this map.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to