AndrewJSchofield commented on code in PR #20126:
URL: https://github.com/apache/kafka/pull/20126#discussion_r2192486583
##########
tools/src/main/java/org/apache/kafka/tools/ShareConsumerPerformance.java:
##########
@@ -153,6 +157,9 @@ private static void consume(List<KafkaShareConsumer<byte[],
byte[]>> shareConsum
// Preserve interrupt status
Thread.currentThread().interrupt();
}
+ for (Future<?> future : futures) {
+ future.get(1, TimeUnit.MILLISECONDS);
Review Comment:
Is there any point in waiting for 1 ms here? Wouldn't `future.get()` be as
effective?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
