aliehsaeedii commented on PR #20127: URL: https://github.com/apache/kafka/pull/20127#issuecomment-3052203144
Thanks, @lucasbru, for the optimization. >The current unit tests of the StickyTasksAssignor pass even after removing the optimization. It’s likely these tests pass because such a closed-loop scenario is rare. However, if that scenario does occur, the tests may fail, leading to flakiness. To avoid introducing flaky tests, it might be best to remove those that specifically check the impact of pairs. Additionally, it would be useful to understand why omitting pairs causes certain tests to fail for `LegacyStickyTaskAssignor`. My assumption is that it’s related to the task ID assignment order, which remains consistent in the legacy implementation but can change in the current approach. While this insight may not directly support the optimization, it is important for verifying the current implementation’s correctness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
