Yunyung commented on code in PR #20130:
URL: https://github.com/apache/kafka/pull/20130#discussion_r2194834969
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterShareGroupOffsetsHandler.java:
##########
@@ -116,13 +116,13 @@ public ApiResult<CoordinatorKey, Map<TopicPartition,
ApiException>> handleRespon
));
} else {
response.data().responses().forEach(topic ->
topic.partitions().forEach(partition -> {
- if (partition.errorCode() != Errors.NONE.code()) {
- final Errors partitionError =
Errors.forCode(partition.errorCode());
- final String partitionErrorMessage =
partition.errorMessage();
- log.debug("AlterShareGroupOffsets request for group id {}
and topic-partition {}-{} failed and returned error {}." +
partitionErrorMessage,
- groupId.idValue, topic.topicName(),
partition.partitionIndex(), partitionError);
+ final Errors partitionError =
Errors.forCode(partition.errorCode());
+ if (partitionError.code() != Errors.NONE.code()) {
Review Comment:
```suggestion
if (partitionError != Errors.NONE) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
