showuon commented on PR #17870:
URL: https://github.com/apache/kafka/pull/17870#issuecomment-3056509013

   Thanks for the explanation, @adixitconfluent !
   
   > in the previous flow, we could not fetch more than 1 MB for each topic 
partition in the share fetch request by default although the overall SFR max 
bytes is 50MB. 
   
   Yes, that's the purpose of the config `max.partition.fetch.bytes`. 
   
   > In the cases of share groups, it might be a case, that not all the 
partitions that are present in the share fetch request can be acquired which 
can lead to under utilisation of request.
   
   This could also happen in normal fetch that some partitions have no more new 
data, which leads to under utilization of request. 
   
   I think my main question is:
   1. This public API change seems to have no discussion with the community, 
nor no clear documentation.
   2. I think this is a good improvement for the utilization of the fetch 
request, so why only in share fetch not normal fetch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to