lucasbru commented on code in PR #20084:
URL: https://github.com/apache/kafka/pull/20084#discussion_r2197192671
##########
docs/streams/developer-guide/security.html:
##########
@@ -70,7 +70,65 @@
the ACL set so that the application has the permissions to
create, read and write
<a class="reference internal"
href="manage-topics.html#streams-developer-guide-topics-internal"><span
class="std std-ref">internal topics</span></a>.</p>
- <p>To avoid providing this permission to your application, you
can create the required internal topics manually.
+ <div class="admonition">
+ <p>Starting with <a class="reference external"
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1071%3A+Streams+Rebalance+Protocol";>KIP-1071</a>(Currently,
it's in the Early Access phase), additional ACLs are required for the new
Streams rebalance protocol. You can enable this protocol by using the
<code>group.protocol=streams</code> configuration:</p>
+ </div>
+
+ <table border="1" class="docutils">
+ <colgroup>
+ <col width="25%">
+ <col width="15%">
+ <col width="20%">
+ <col width="40%">
+ </colgroup>
+ <thead valign="bottom">
+ <tr class="row-odd"><th class="head">API PROTOCOL</th>
+ <th class="head">OPERATION</th>
+ <th class="head">Resource</th>
+ <th class="head">Notes</th>
+ </tr>
+ </thead>
+ <tbody valign="top">
+ <tr class="row-even">
+ <td>STREAMS_GROUP_HEARTBEAT</td>
+ <td>Read</td>
+ <td>Group</td>
+ <td>Required for the application's streams groups</td>
Review Comment:
```suggestion
<td>Required for the application's streams group</td>
```
##########
docs/streams/developer-guide/security.html:
##########
@@ -70,7 +70,65 @@
the ACL set so that the application has the permissions to
create, read and write
<a class="reference internal"
href="manage-topics.html#streams-developer-guide-topics-internal"><span
class="std std-ref">internal topics</span></a>.</p>
- <p>To avoid providing this permission to your application, you
can create the required internal topics manually.
+ <div class="admonition">
+ <p>Starting with <a class="reference external"
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1071%3A+Streams+Rebalance+Protocol";>KIP-1071</a>(Currently,
it's in the Early Access phase), additional ACLs are required for the new
Streams rebalance protocol. You can enable this protocol by using the
<code>group.protocol=streams</code> configuration:</p>
+ </div>
+
+ <table border="1" class="docutils">
+ <colgroup>
+ <col width="25%">
+ <col width="15%">
+ <col width="20%">
+ <col width="40%">
+ </colgroup>
+ <thead valign="bottom">
+ <tr class="row-odd"><th class="head">API PROTOCOL</th>
+ <th class="head">OPERATION</th>
+ <th class="head">Resource</th>
+ <th class="head">Notes</th>
+ </tr>
+ </thead>
+ <tbody valign="top">
+ <tr class="row-even">
+ <td>STREAMS_GROUP_HEARTBEAT</td>
+ <td>Read</td>
+ <td>Group</td>
+ <td>Required for the application's streams groups</td>
+ </tr>
+ <tr class="row-odd">
+ <td>STREAMS_GROUP_HEARTBEAT</td>
+ <td>Create</td>
+ <td>Cluster <i>or</i> Topic</td>
+ <td>
+ Required only if auto-creating internal topics.<br>
+ • <code>Create</code> on Cluster resource<br>
+ • or <code>Create</code> on all topics in
StateChangelogTopics and RepartitionSourceTopics<br>
+ Not required if internal topics are pre-created
+ </td>
+ </tr>
+ <tr class="row-even">
+ <td>STREAMS_GROUP_HEARTBEAT</td>
+ <td>Describe</td>
+ <td>Topic</td>
+ <td>Required for all topics included in the message</td>
+ </tr>
+ <tr class="row-odd">
+ <td>STREAMS_GROUP_DESCRIBE</td>
+ <td>Describe</td>
+ <td>Group</td>
+ <td>Required for the application's streams groups</td>
Review Comment:
```suggestion
<td>Required for the application's streams group</td>
```
##########
docs/streams/developer-guide/security.html:
##########
@@ -70,7 +70,65 @@
the ACL set so that the application has the permissions to
create, read and write
<a class="reference internal"
href="manage-topics.html#streams-developer-guide-topics-internal"><span
class="std std-ref">internal topics</span></a>.</p>
- <p>To avoid providing this permission to your application, you
can create the required internal topics manually.
+ <div class="admonition">
+ <p>Starting with <a class="reference external"
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1071%3A+Streams+Rebalance+Protocol";>KIP-1071</a>(Currently,
it's in the Early Access phase), additional ACLs are required for the new
Streams rebalance protocol. You can enable this protocol by using the
<code>group.protocol=streams</code> configuration:</p>
+ </div>
+
+ <table border="1" class="docutils">
+ <colgroup>
+ <col width="25%">
+ <col width="15%">
+ <col width="20%">
+ <col width="40%">
+ </colgroup>
+ <thead valign="bottom">
+ <tr class="row-odd"><th class="head">API PROTOCOL</th>
+ <th class="head">OPERATION</th>
+ <th class="head">Resource</th>
+ <th class="head">Notes</th>
+ </tr>
+ </thead>
+ <tbody valign="top">
+ <tr class="row-even">
+ <td>STREAMS_GROUP_HEARTBEAT</td>
+ <td>Read</td>
+ <td>Group</td>
+ <td>Required for the application's streams groups</td>
+ </tr>
+ <tr class="row-odd">
+ <td>STREAMS_GROUP_HEARTBEAT</td>
+ <td>Create</td>
+ <td>Cluster <i>or</i> Topic</td>
+ <td>
+ Required only if auto-creating internal topics.<br>
+ • <code>Create</code> on Cluster resource<br>
+ • or <code>Create</code> on all topics in
StateChangelogTopics and RepartitionSourceTopics<br>
+ Not required if internal topics are pre-created
+ </td>
+ </tr>
+ <tr class="row-even">
+ <td>STREAMS_GROUP_HEARTBEAT</td>
+ <td>Describe</td>
+ <td>Topic</td>
+ <td>Required for all topics included in the message</td>
Review Comment:
```suggestion
<td>Required for all topics used in the application's
topology, when first joining.</td>
```
##########
docs/streams/developer-guide/security.html:
##########
@@ -70,7 +70,65 @@
the ACL set so that the application has the permissions to
create, read and write
<a class="reference internal"
href="manage-topics.html#streams-developer-guide-topics-internal"><span
class="std std-ref">internal topics</span></a>.</p>
- <p>To avoid providing this permission to your application, you
can create the required internal topics manually.
+ <div class="admonition">
+ <p>Starting with <a class="reference external"
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1071%3A+Streams+Rebalance+Protocol";>KIP-1071</a>(Currently,
it's in the Early Access phase), additional ACLs are required for the new
Streams rebalance protocol. You can enable this protocol by using the
<code>group.protocol=streams</code> configuration:</p>
Review Comment:
There is a space missing. Also, it's enough for this to be included in 4.2
documentation, at that point we are not in EA anymore.
```suggestion
<p>If the <a class="reference external"
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1071%3A+Streams+Rebalance+Protocol";>streams
rebalance protocol</a> is enabled by setting
<code>group.protocol=streams</code>, the following ACLs are required on the
topic and group resources:</p>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
