shashankhs11 opened a new pull request, #20149: URL: https://github.com/apache/kafka/pull/20149
This PR addresses [KAFKA-14405 JIRA](https://issues.apache.org/jira/browse/KAFKA-14405) and builds upon significant work done from #12988. ### Initial Problem It's too easy for users to try overriding one of the client configs that Streams hardcodes, and since we just silently ignore it there's no good way for them to tell their config is not being used. Sometimes this may be harmless but in cases like the Producer's partitioner, there could be important application logic that's never being invoked. When processing user configs in StreamsConfig, we should check for all these configs and log a warning when any of them have been set ### New Problem During the work in #12988, it was found that - - Users could bypass Kafka Streams' controlled configurations by using specific consumer prefixes (e.g., `main.consumer.allow.auto.create.topics=true` instead of `consumer.allow.auto.create.topics=true`). - Similar bypasses existed for global consumer and producer configurations [Confirmed here](https://github.com/apache/kafka/pull/12988#issuecomment-1710983828) - Root cause of bypass [here](https://github.com/apache/kafka/pull/12988#issuecomment-1752128811) ### Summary of Work from previous PR - New configuration architecture separating "defaults" vs "controlled" configs. More details [can be found in this review comment](https://github.com/apache/kafka/pull/12988#issuecomment-2094869760) - There was also a discussion to handle `ProducerConfig.PARTITIONER_CLASS_CONFIG`. But this needs a KIP as per the [discussion here](https://github.com/apache/kafka/pull/12988#discussion_r1645646195) ### Pending Work - A few more configs need to be covered; `group.id`, `client.id`, `client.instance.id`, `auto.offset.reset` - More test cases need to be written to cover the current changes and upcoming changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
