squah-confluent commented on code in PR #20055:
URL: https://github.com/apache/kafka/pull/20055#discussion_r2200219203
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -3463,15 +3488,16 @@ private ConsumerGroupMember maybeReconcile(
BiFunction<Uuid, Integer, Integer> currentPartitionEpoch,
int targetAssignmentEpoch,
Assignment targetAssignment,
+ Map<String, ResolvedRegularExpression> resolvedRegularExpressions,
+ boolean hasSubscriptionChanged,
List<ConsumerGroupHeartbeatRequestData.TopicPartitions>
ownedTopicPartitions,
List<CoordinatorRecord> records
) {
- if (member.isReconciledTo(targetAssignmentEpoch)) {
Review Comment:
I moved this down into the `AssignmentBuilder` classes in response to a
comment from @dajac.
https://github.com/apache/kafka/pull/20055#discussion_r2171303165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
