kevin-wu24 commented on code in PR #20136:
URL: https://github.com/apache/kafka/pull/20136#discussion_r2200806228
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -135,6 +135,15 @@ object StorageTool extends Logging {
featureNamesAndLevels(_).foreachEntry {
(k, v) => formatter.setFeatureLevel(k, v)
})
+ if (!config.quorumConfig.voters().isEmpty &&
+ (namespace.getString("initial_controllers") != null ||
namespace.getBoolean("standalone"))) {
Review Comment:
> or, thoughts on moving this check to be with the existing config
validations under L155?
I put this before L155 because at that point we have already made calls to
modify formatter state if one of `--standalone` or `--initial-controllers` is
set. Basically I think it is cleaner to fail first if the set up is invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
