squah-confluent commented on code in PR #20024:
URL: https://github.com/apache/kafka/pull/20024#discussion_r2202026091


##########
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##########
@@ -421,6 +452,27 @@ class GroupCoordinatorBaseRequestTest(cluster: 
ClusterInstance) {
     groupResponse
   }
 
+  protected def fetchOffset(
+    topic: String,
+    partition: Int,
+    groupId: String

Review Comment:
   nit: The other methods in this class put the groupId as the first parameter. 
Could we re-order the parameters for consistency?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to