junrao commented on PR #20137:
URL: https://github.com/apache/kafka/pull/20137#issuecomment-3070867513

   > Maybe I lack some understanding but I don't get how the PR solves the 
issue related to the exception mentioning "maximum version is 4.2-IV1" (in a 
4.1 release) because it's coming from the latest element of the VERSIONS 
collection filled with all MetadataVersion enum values.
   
   @ppatierno : For all production MVs (those <= latest production), we also 
add the release version (e.g. 4.1) in IBP_VERSIONS. This way, 4.1 becomes a 
valid MV. 
   ```
           for (MetadataVersion metadataVersion : VERSIONS) {
               if (metadataVersion.isProduction()) {
                   maxInterVersion.put(metadataVersion.release, 
metadataVersion);
               }
   ```
   Regarding the confusion on the error message, this is a generic error 
message when an MV can't be found. 4.2-IV1 is the latest testing version while 
4.1-IV1 is the lates production version. If unstable.feature.versions.enable is 
enabled, non-production versions could be used. Otherwise, only production 
versions could be used. We could include both in the error message to make it 
clear.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to