bbejeck commented on code in PR #20166:
URL: https://github.com/apache/kafka/pull/20166#discussion_r2205762340
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -579,10 +579,12 @@ static KafkaAdminClient createInternal(AdminClientConfig
config,
Time time) {
Metrics metrics = null;
String clientId = generateClientId(config);
+ List<MetricsReporter> reporters =
CommonClientConfigs.metricsReporters(clientId, config);
Optional<ClientTelemetryReporter> clientTelemetryReporter =
CommonClientConfigs.telemetryReporter(clientId, config);
+ clientTelemetryReporter.ifPresent(reporters::add);
Review Comment:
Good point, but it is already handled. By closing the `metrics` instance,
it will close all underlying `MetricReporter` instances that get passed in as a
constructor parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
