chia7712 commented on code in PR #20167:
URL: https://github.com/apache/kafka/pull/20167#discussion_r2205794747
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -3603,6 +3603,7 @@ class ReplicaManagerTest {
val tidp1 = new TopicIdPartition(topicId, tp1)
val replicaManager = setupReplicaManagerWithMockedPurgatories(new
MockTimer(time), aliveBrokerIds = Seq(0, 1, 2), enableRemoteStorage = true,
shouldMockLog = true, remoteFetchQuotaExceeded = Some(false))
+ when(replicaManager.logManager.getOrCreateLog(tp0, isNew = false, isFuture
= false, Optional.empty(), None).topicId()).thenReturn(Optional.of(topicId))
Review Comment:
It is a bit weird to me that `setupMockLog` allows `UnifiedLog` to return
"different" topic ids. Perhaps we should enhance `createLogManager` to accept
multiple `UnifiedLog`s for the test
`testOffsetOutOfRangeExceptionWhenReadFromLog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
