sjhajharia commented on PR #20164: URL: https://github.com/apache/kafka/pull/20164#issuecomment-3072058105
Thanks @apoorvmittal10 for the review. I have added a couple of tests as suggested by you - `testHandleShareAcknowledgeRequestQuotaTagsVerification` and `testHandleShareFetchWithAcknowledgementQuotaTagsVerification` to test the two situations as you had mentioned. I have also refactored the code a bit to overload the `buildRequest()` method. Please re-review when possible. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
