AndrewJSchofield commented on code in PR #19886:
URL: https://github.com/apache/kafka/pull/19886#discussion_r2207431260
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -144,6 +145,18 @@ public void tryConnect(Node node) {
* @param currentTimeMs current time
*/
public void poll(final long timeoutMs, final long currentTimeMs) {
+ poll(timeoutMs, currentTimeMs, false);
+ }
+
+ /**
+ * Returns the responses of the sent requests. This method will try to
send the unsent requests, poll for responses,
Review Comment:
nit: The poll methods do not return the responses of the sent requests. They
return nothing at all. I think the rest of the comment apart from the first
sentence is OK. The other poll method has a similar mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
