showuon commented on code in PR #20161:
URL: https://github.com/apache/kafka/pull/20161#discussion_r2209127122
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -3788,23 +3787,7 @@ public void complete() {
}
}
- private static final class Registration<T> {
- private final Ops ops;
- private final Listener<T> listener;
-
- private Registration(Ops ops, Listener<T> listener) {
- this.ops = ops;
- this.listener = listener;
- }
-
- private Ops ops() {
- return ops;
- }
-
- private Listener<T> listener() {
- return listener;
- }
-
+ private record Registration<T>(KafkaRaftClient.Registration.Ops ops,
Listener<T> listener) {
Review Comment:
The `record` keyword starts support in jdk 14, but client is still
supporting jdk 11 (raft module will be used by `tool` module). So I think it'd
be better we revert this change for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
