mjsax commented on PR #20183: URL: https://github.com/apache/kafka/pull/20183#issuecomment-3081653168
Thanks for the PR. I am not sure if I fully understand. I believe this issue with this test was introduced when `streams` protocol was added. But why does it modify the behavior in the way you describe? What you describe sounds very generic and I am wondering why it was not a problem for `classic` protocol? Btw: Looking into the test, it seems we are leaking `KafkaStreams()` instances, as we don't `close()` them. Can we extend this PR to use try-with-resource to ensure we don't leak instances? Another minor fix could be, to replace `Serdes.Integer().getClass()` in the config setup with `Serdes.IntegerSerde.class`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
