frankvicky commented on code in PR #20185:
URL: https://github.com/apache/kafka/pull/20185#discussion_r2212043512
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,9 +128,22 @@ object StorageTool extends Logging {
setIgnoreFormatted(namespace.getBoolean("ignore_formatted")).
setControllerListenerName(config.controllerListenerNames.get(0)).
setMetadataLogDirectory(config.metadataLogDir)
- Option(namespace.getString("release_version")).foreach(
- releaseVersion => formatter.
- setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion)))
+
+ def metadataVersionsToString(first: MetadataVersion, last:
MetadataVersion): String = {
+ val versions = MetadataVersion.VERSIONS.slice(first.ordinal,
last.ordinal + 1)
+ versions.map(_.toString).mkString(", ")
+ }
+ Option(namespace.getString("release_version")).foreach(releaseVersion => {
+ try {
+
formatter.setReleaseVersion(MetadataVersion.fromVersionString(releaseVersion))
+ } catch {
+ case _: Throwable =>
+ throw new TerseFailure("Unknown metadata.version " + releaseVersion +
+ ". Supported metadata.version are " + metadataVersionsToString(
+ MetadataVersion.MINIMUM_VERSION,
MetadataVersion.latestProduction()))
+ }
Review Comment:
Could we use an interpolated string here?
```suggestion
throw new TerseFailure(s"Unknown metadata.version $releaseVersion.
Supported metadata.version are ${
metadataVersionsToString(
MetadataVersion.MINIMUM_VERSION,
MetadataVersion.latestProduction())
}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
