lucasbru commented on code in PR #17942: URL: https://github.com/apache/kafka/pull/17942#discussion_r2216093651
########## streams/src/main/java/org/apache/kafka/streams/errors/LogAndContinueExceptionHandler.java: ########## @@ -17,47 +17,27 @@ package org.apache.kafka.streams.errors; import org.apache.kafka.clients.consumer.ConsumerRecord; -import org.apache.kafka.streams.processor.ProcessorContext; +import org.apache.kafka.streams.StreamsConfig; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.util.Map; +import static org.apache.kafka.streams.errors.internals.ExceptionHandlerUtils.maybeBuildDeadLetterQueueRecords; + /** * Deserialization handler that logs a deserialization exception and then * signals the processing pipeline to continue processing more records. */ public class LogAndContinueExceptionHandler implements DeserializationExceptionHandler { private static final Logger log = LoggerFactory.getLogger(LogAndContinueExceptionHandler.class); + private String deadLetterQueueTopic = null; - /** - * @deprecated Since 3.9. Use {@link #handle(ErrorHandlerContext, ConsumerRecord, Exception)} instead. - */ - @SuppressWarnings("deprecation") - @Deprecated @Override - public DeserializationHandlerResponse handle(final ProcessorContext context, Review Comment: Ah, I was asking because this PR seems to remove it. But I realize now that there is still a default implementation in the interface that throws a `throw new UnsupportedOperationException();`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org