chia7712 commented on code in PR #20115:
URL: https://github.com/apache/kafka/pull/20115#discussion_r2217843694


##########
metadata/src/main/java/org/apache/kafka/metadata/properties/PropertiesUtils.java:
##########
@@ -36,7 +36,7 @@ public final class PropertiesUtils {
      *
      * @param props         The Properties object.
      * @param path          The file to write to.
-     * @throws IOException
+     * @throws IOException  If any I/O error occurs.

Review Comment:
   ditto



##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1697,7 +1692,7 @@ private void registerGeneratePeriodicPerformanceMessage() 
{
      *
      * This task periodically expires delegation tokens.
      *
-     * @param checkIntervalNs
+     * @param checkIntervalNs The check interval in nanoseconds.

Review Comment:
   It seems to me the docs are nothing more than the naming. Perhaps we should 
remove it instead.



##########
metadata/src/test/java/org/apache/kafka/controller/metrics/ControllerMetricsTestUtils.java:
##########
@@ -64,18 +64,11 @@ enum FakePartitionRegistrationType {
     public static PartitionRegistration fakePartitionRegistration(
         FakePartitionRegistrationType  type

Review Comment:
   Could you please remove redundant space also?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to