sjhajharia commented on code in PR #20091:
URL: https://github.com/apache/kafka/pull/20091#discussion_r2217871354
##########
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##########
@@ -326,11 +322,11 @@ private static Set<Row>
enumerateRows(ManifestWorkspace.SourceWorkspace<?> works
rowAliases.add(PluginUtils.prunedName(pluginDesc));
rows.add(newRow(workspace, pluginDesc.className(), new
ArrayList<>(rowAliases), pluginDesc.type(), pluginDesc.version(), true));
// If a corresponding manifest exists, mark it as loadable by
removing it from the map.
- nonLoadableManifests.getOrDefault(pluginDesc.className(),
Collections.emptySet()).remove(pluginDesc.type());
+ nonLoadableManifests.getOrDefault(pluginDesc.className(), new
HashSet<>()).remove(pluginDesc.type());
Review Comment:
Sure. I have dropped the fix from this PR and added a comment. Once this PR
goes in, I will raise a new one to fix the same.
Does that sound fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
