kamalcph commented on code in PR #20205:
URL: https://github.com/apache/kafka/pull/20205#discussion_r2225075612


##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -1639,20 +1639,20 @@ static boolean 
isRemoteSegmentWithinLeaderEpochs(RemoteLogSegmentMetadata segmen
      */
     // Visible for testing
     static NavigableMap<Integer, Long> 
buildFilteredLeaderEpochMap(NavigableMap<Integer, Long> leaderEpochs) {

Review Comment:
   Could you also remove the example mentioned in the javadoc? The scenario is 
already covered as part of unit test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to