jiafu1115 commented on code in PR #20007: URL: https://github.com/apache/kafka/pull/20007#discussion_r2228488391
########## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ########## @@ -368,6 +368,12 @@ private void initializeResources(TopicBasedRemoteLogMetadataManagerConfig rlmmCo } catch (KafkaException e) { log.error("Encountered error while initializing topic-based RLMM resources", e); initializationFailed = true; + } finally { + Utils.closeQuietly(adminClient, "AdminClient"); Review Comment: yes. the code had been refactored so that I make a mistake when fixing conflict. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org