kevin-wu24 commented on code in PR #20242:
URL: https://github.com/apache/kafka/pull/20242#discussion_r2240023878


##########
metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java:
##########
@@ -136,6 +136,7 @@ public String replay(RemoveTopicRecord record) {
         String topicName;
         if (topicDelta != null) {
             topicName = topicDelta.image().name();
+            createdTopics.remove(topicName);

Review Comment:
   We need to make sure that we add the topic ID to the `deletedTopicIds` map 
as well. One way to do this is. to check both the `TopicsImage` and the 
`createdTopics` map, and then add + remove the topic ID from the appropriate 
maps.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to