junrao commented on code in PR #20237: URL: https://github.com/apache/kafka/pull/20237#discussion_r2244126836
########## docs/ops.html: ########## @@ -4499,8 +4499,15 @@ <h4 class="anchor-heading"><a id="eligible_leader_replicas_upgrade" class="ancho <h4 class="anchor-heading"><a id="eligible_leader_replicas_tool" class="anchor-link"></a><a href="#eligible_leader_replicas_tool">Tool</a></h4> <p>The ELR fields can be checked through the API DescribeTopicPartitions. The admin client can fetch the ELR info by describing the topics. - Also note that, if <code>min.insync.replicas</code> is updated for a topic, the ELR field will be cleaned. If cluster default min ISR is updated, - all the ELR fields will be cleaned.</p> + Note that when the ELR feature is enabled: + <ul> + <li>The override of <code>min.insync.replicas</code> in broker-level will be removed.</li> Review Comment: We probably also want to warn the users that if they previously only set min.insync.replicas at the broker level, once they enable ELR, this info will be lost and they need to reset that at the cluster level. Is the above correct @CalvinConfluent ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
