aliehsaeedii commented on code in PR #20284:
URL: https://github.com/apache/kafka/pull/20284#discussion_r2254175751
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##########
@@ -3930,8 +3932,16 @@ public void
testStreamsProtocolRunOnceWithoutProcessingThreadsMissingSourceTopic
.setStatusCode(StreamsGroupHeartbeatResponse.Status.MISSING_SOURCE_TOPICS.code())
.setStatusDetail("Missing source topics")
));
+
+ // First call should not throw exception (within timeout)
+ thread.runOnceWithoutProcessingThreads();
+
Review Comment:
The same suggestion (bellow) here.
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##########
@@ -3930,8 +3932,16 @@ public void
testStreamsProtocolRunOnceWithoutProcessingThreadsMissingSourceTopic
.setStatusCode(StreamsGroupHeartbeatResponse.Status.MISSING_SOURCE_TOPICS.code())
.setStatusDetail("Missing source topics")
));
+
+ // First call should not throw exception (within timeout)
+ thread.runOnceWithoutProcessingThreads();
+
Review Comment:
The same suggestion (below) here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
