mjsax commented on code in PR #20325:
URL: https://github.com/apache/kafka/pull/20325#discussion_r2275144231
##########
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##########
@@ -64,6 +77,9 @@ class DefaultAutoTopicCreationManager(
) extends AutoTopicCreationManager with Logging {
private val inflightTopics = Collections.newSetFromMap(new
ConcurrentHashMap[String, java.lang.Boolean]())
+ private val topicCreationErrorCache = new ConcurrentHashMap[String,
CachedTopicCreationError]()
+ private val errorCacheTtlMs = config.requestTimeoutMs.toLong * 3 // 3x
request timeout
+ private val maxCacheSize = 1000
Review Comment:
Not sure if we would need a KIP (we would need one, if we would make it
configurable). But I would expect error rate to be low. If there is some issue
at some point, we can still limit it in the future, and with a TTL we would
expires old entries anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
