lucasbru commented on code in PR #20244:
URL: https://github.com/apache/kafka/pull/20244#discussion_r2318241369
##########
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##########
@@ -152,12 +155,11 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness {
shareConsumerConfig.putIfAbsent(ConsumerConfig.GROUP_ID_CONFIG, "group")
shareConsumerConfig.putIfAbsent(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer].getName)
shareConsumerConfig.putIfAbsent(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer].getName)
-
streamsConsumerConfig.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG,
bootstrapServers())
streamsConsumerConfig.putIfAbsent(ConsumerConfig.GROUP_ID_CONFIG, "group")
streamsConsumerConfig.putIfAbsent(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer].getName)
streamsConsumerConfig.putIfAbsent(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer].getName)
-
+
Review Comment:
```suggestion
```
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -3603,7 +3630,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val broker0Resource = new ConfigResource(ConfigResource.Type.BROKER, "0")
client.incrementalAlterConfigs(util.Map.of(broker0Resource,
util.List.of(new AlterConfigOp(new
ConfigEntry(QuotaConfig.LEADER_REPLICATION_THROTTLED_RATE_CONFIG, "123"),
- AlterConfigOp.OpType.SET),
+ AlterConfigOp.OpType.SET),
Review Comment:
```suggestion
AlterConfigOp.OpType.SET),
```
##########
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##########
@@ -152,12 +155,11 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness {
shareConsumerConfig.putIfAbsent(ConsumerConfig.GROUP_ID_CONFIG, "group")
shareConsumerConfig.putIfAbsent(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer].getName)
shareConsumerConfig.putIfAbsent(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer].getName)
Review Comment:
```suggestion
shareConsumerConfig.putIfAbsent(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
classOf[ByteArrayDeserializer].getName)
```
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -3809,7 +3836,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
val longTopicName = String.join("", Collections.nCopies(249, "x"))
val invalidTopicName = String.join("", Collections.nCopies(250, "x"))
val newTopics2 = util.List.of(new NewTopic(invalidTopicName, 3, 3.toShort),
- new NewTopic(longTopicName, 3, 3.toShort))
+ new NewTopic(longTopicName, 3, 3.toShort))
Review Comment:
```suggestion
new NewTopic(longTopicName, 3, 3.toShort))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
